search

fusion-engineering / inline-python

Inline Python code directly in your Rust code
https://docs.rs/inline-python
BSD 2-Clause "Simplified" License
1.15k stars 37 forks source link

Version 0.5.0 #19

Closed m-ou-se closed 4 years ago

m-ou-se commented 4 years ago

What do we want to do with existing code that uses #![context = &c]? Right now, the code in this PR will just give that line to Python, which will see it as a comment because of the #.

Should we panic, give a warning, or still support this syntax?

de-vri-es commented 4 years ago

I think we should give an error if we find it. Not very nice if it is silently ignored.

m-ou-se commented 4 years ago

It now gives this error:

screenshot

de-vri-es commented 4 years ago

Cool. Might be nice to highlight the entire attribute for the error, but this is certainly good enough.