search

fusion-engineering / inline-python

Inline Python code directly in your Rust code
https://docs.rs/inline-python
BSD 2-Clause "Simplified" License
1.15k stars 37 forks source link

Upgrade to PyO3 0.17 #50

Closed Jules-Bertholet closed 2 years ago

nikhilmitrax commented 2 years ago

Are there any plans to merge this in?

de-vri-es commented 2 years ago

Might be good to run cargo fmt to get past the pesky CI :)

Jules-Bertholet commented 2 years ago

It seems the CI runs on the code rebased onto the latest master, where cargo fmt failed, even though it passed on my un-rebased local copy... rebased and re-formatted, should pass now

de-vri-es commented 2 years ago

It seems the CI runs on the code rebased onto the latest master, where cargo fmt failed, even though it passed on my un-rebased local copy... rebased and re-formatted, should pass now

Ahh, makes sense.

de-vri-es commented 2 years ago

Looks good! Thanks for the PR! No API changes, so we should be good :D

de-vri-es commented 2 years ago

I'll try to get to a release today or tomorrow. Feel free to ping me if I forget.

Jules-Bertholet commented 2 years ago

@de-vri-es ping

de-vri-es commented 2 years ago

Thanks for the reminder. Published 0.10.0 :)

And thanks again for the PR!