search

fusion-flap / flap

Fusion Library of Analysis Programs
MIT License
11 stars 5 forks source link

Data_source is missing in get_data #20

Closed thelampire closed 4 years ago

thelampire commented 5 years ago

data_object.py line 3670 Original code:
d = f(exp_id, name, no_data=no_data, options=options, coordinates=_coordinates, data_source=None) Proposed modification: d = f(exp_id, name, no_data=no_data, options=options, coordinates=_coordinates, data_source=data_source)

Sometimes the code is working, sometimes it doesn't. If the get_data function doesn't have the default data_source in it, as it isn't in e.g. MDSPlus, the code fails. I could in theory modify the code, but my proposed pull request for plot.py hasn't yet been approved still and I thought this might be a better option.

thelampire commented 4 years ago

This has been fixed lately. Issue closed.