plot.py difference between anim-image and anim-contour

fusion-flap / flap

Fusion Library of Analysis Programs

MIT License

11 stars 5 forks source link

plot.py difference between anim-image and anim-contour #57

Closed thelampire closed 4 years ago

thelampire commented 4 years ago

anim-image and anim-contour is showing different images. They are 90 degrees rotated compared to each other. Anim-image is showing the right orientation, anim-contour isn't.

thelampire commented 4 years ago

Anim image is the incorrect one. Actually, I think that the returned pdd_list is not right. My data is indexed in the following way: [time,pixel x, pixel y] The dimension pdd_list[0,1,2].value.dimension_list is then [1] [2] [0] which will make the condition for transposing False, because coord_x.dimension_list[0] = 1. Hence the (y,x) indexing of matplotlib is not working. I couldn't really find the source of the problem so I only modified the == to != at anim-image to get it working. Sanyi, if you have time, please check what could cause such an error.

thelampire commented 4 years ago

This is getting even more serious. The following has happened:

Finally, I calculated the CCF between one pixel and all the others
The resulting object had coordinates of 'Image x', 'Image y', 'Time lag' with Dims: 0,1,2 respectively. This rotates the resulting anim-image because of that condition mentioned above. The original coordinates of the object were like this: 'Time', 'Image x', 'Image y' with dims 0,1,2 respectively.

Should I start working on fixing this?

thelampire commented 4 years ago

This is fixed in the latest push of thelampire-patch-02. The original code is left in as comments because it is not my part which I modified.