fusion-flap / flap

Fusion Library of Analysis Programs
MIT License
11 stars 5 forks source link

No _acf function in spectral_analysis.py #58

Closed thelampire closed 3 years ago

thelampire commented 4 years ago

I didn't find any autocorrelation calculation tools nor an option at flap.ccf to calculate the autocorrelation. In theory I could just calculate all the ccf functions in the video and select the autocorrelation ones, but that would take too much time.

Is there a reason why flap.acf is not implemented?

sandorzoletnik commented 4 years ago

I was thinking about this, as we have an APSD and CPSD. But it did not look very interesting to calculate the ACFs. It is possible to do this, needs a few hours, but there are other issues before it.. Let's keep this as an issue.

thelampire commented 3 years ago

I believe this can be done by setting the reference and the data object to the same and normalization to False. This doesn't need to be a separate method I believe.