search

fusion-flap / flap

Fusion Library of Analysis Programs
MIT License
11 stars 5 forks source link

Trend removal is not doing anything #74

Closed thelampire closed 3 years ago

thelampire commented 4 years ago

The given numpy array (d) stays within the function and isn't modified. This happens when I am using it as flap.trend.removal_func(d, 0, ['Poly',3]). If I plot the d before and after the trend removal, nothing happens, the same data is plotted.

It is working as an internal function, so there is nothing wrong with _trend_removal() it is just not working when it is converted into an outside accessible function.

thelampire commented 4 years ago

The return_trend option is working, but without that the trend is not subtract-able/ed from the data.

thelampire commented 4 years ago

Furthermore, the return_trend=True does not do anything for a single time series, but it does work for multiple.

thelampire commented 4 years ago

Sandor, please comment on this. I can fix it quickly, but I don't know what the exact intention was behind this trend removal and how and where it is used ecactly. I don't want to modify anything which is supposed to work the way it does, but I am just not using it in the way it is supposed to.

thelampire commented 3 years ago

This hasn't come up ever since, I am closing the issue.