search

fusion-flap / flap

Fusion Library of Analysis Programs
MIT License
11 stars 5 forks source link

Slicing is working inconsistently #79

Closed thelampire closed 4 years ago

thelampire commented 4 years ago

I am trying to slice the 64x80 GPI image down to whatever ROI. When I give it a flap.Intervals(0,64), flap.Intervals(0,81) slicing in both directions, only a 63 by 80 slice is given instead of the entire video.

thelampire commented 4 years ago

If I apply the same slicing over and over again, the data gets smaller and smaller by one index in both directions.

thelampire commented 4 years ago

1D slicing is working consistently, except when the entire range is given. In that case it is cutting down the last element again. (Sorry for the spam)

thelampire commented 4 years ago

The error was in data_pbject.py/slice_data/simple_slice_index at the return. A slice works just like a range(). The last value is not included. If I set the flap.Intervals to (0,80), when the data's image x is from 0 to 79, it was not returning a slice(0,80) because the range was only until 79. The following return statement fixes the problem at line 1598: return slice(start_index, stop_index+1, step_index)