search

fusion-flap / flap

Fusion Library of Analysis Programs
MIT License
11 stars 5 forks source link

Photon peak subtraction #87

Closed thelampire closed 3 years ago

thelampire commented 3 years ago

https://github.com/fusion-flap/flap/blob/ff082580524f7f3e26b1f5c193ae992d4115a909/flap/spectral_analysis.py#L1677 https://github.com/fusion-flap/flap/blob/d19b8fbc869f9e9e185ed59bb403ca8276ed8aa5/flap/spectral_analysis.py#L1661

I figured out that the photon peak subtraction should be performed here. However, I don't understand why there is a difference between line 1677 and 1661 at the axis. Shouldn't they both start from axis= corr_dimension_start?

I can't really test this in a general way. I have 1D and 2D data, but nothing complicated.

thelampire commented 3 years ago

My bad, the reference channel is shited to the start while the other acf is shifted to the end. I'm still curious why this is happening, though.

thelampire commented 3 years ago

This is finished, it needs to be merged.

thelampire commented 3 years ago

Merging needs to be approved, otherwise closing the issue.