fusionalliance / starter-kit

Standards
MIT License
2 stars 0 forks source link

Image optimization #20

Closed davidragsdale closed 4 years ago

davidragsdale commented 4 years ago

Using Webpack. Images can be added as an entry point then emit those as files separate from the JS bundle.

davidragsdale commented 4 years ago

Here is a process flow from ImageOptim. I'll try to post specific settings as I identify them.

Reference: ImageOptim/Backend/Job.m/doEnqueueWorkersInCPUQueue ImageOptim/Resources/defaults.plist http://www.advancemame.it/doc-advpng

InsideDown commented 4 years ago

I have an image minimizer in place I can add as a PR branched from 'release/phase-1'. It just uses 'image-webpack-loader' defaults; seems mostly fine that way.

Since we don't really have an entry point set up in the current setup, not sure the best way this should be organized. I can put a placeholder .js entry point in, but the setup is going to determine how these need to be configured. Thoughts, @davidragsdale?

davidragsdale commented 4 years ago

A .js entry point is fine for now. There's several different ways I know this can be handled and I don't entirely like any of them. An explicit entry point for them is as good as any right now.

InsideDown commented 4 years ago

I've added an image minification branch here: https://github.com/quicksolutions/starter-kit/blob/phase-1/imagemin

@davidragsdale - I'm not sure what branch to be branching from, so currently I did it off of 'release/phase-1'. I can merge these changes into whatever branch they need to be. A few comments:

davidragsdale commented 4 years ago

Completed in #26