search

fusionbox / django-pyscss

Makes it easier to use PyScss in Django
https://pypi.python.org/pypi/django-pyscss
BSD 2-Clause "Simplified" License
19 stars 13 forks source link

Put the original path at the end in get_possible_paths #12

Closed deshipu closed 10 years ago

deshipu commented 10 years ago

Make it try all the combinations of prefixes and suffixes first, and then try the original path. This way if there is a directory named the same as our file, but without the extension and/or prefix, we don't try to open it and avoid raising IOError.

Fixes #10.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 4b294175c84399547385c5505a52b7876082a1b8 on deshipu:master into d7f1b849a04437a04443d68957717179b6b4d7d3 on fusionbox:master.

acatton commented 10 years ago

@deshipu could you rebase on the test-for-path-conflicts branch? I added this commit 56c7db6e2b09f8.

This looks concise and simple. I like it. Let's wait for @rockymeza opinion on this pull request since I'm not 100% sure about the logic of this code.

deshipu commented 10 years ago

I have no idea how to update this pull request with the rebased version, so I will just make a new one.

rockymeza commented 10 years ago

@deshipu, thank so much for this doing this and thanks for using django-pyscss.

Just so you know. If you rebase your branch, you can force push and github will update the pull request. For example:

git fetch upstream
git rebase upstream/test-for-path-conflicts
git push -f origin master