fusionbox / django-pyscss

Makes it easier to use PyScss in Django
https://pypi.python.org/pypi/django-pyscss
BSD 2-Clause "Simplified" License
19 stars 13 forks source link

Fix #19, Make the import compatible with pyScss version 1.3 #20

Closed deshipu closed 10 years ago

deshipu commented 10 years ago

In 1.3 they removed some names from init, so we have to import them from their corresponding modules inside pyscss.

acatton commented 10 years ago

Thank you @deshipu for this pull request. You're really hunting bugs down!

This fixes the bug with the new version of pyscss but some of our users might be using an older version of pyScss. This is breaking as the tests show. Could you extend travis' test matrix to test with the old version of pyScss and the new one?

You might want to wrap your import in a try...except ImportError: # pyScss < version statement.

rockymeza commented 10 years ago

I've been talking to @eevee from the PyScss project and they think there are going to be some bigger changes that end up breaking more of django-pyscss, I was thinking that the current version of django-pyscss would only support pyscss==1.2, and the next version would only support pyscss==1.3.

If you guys find that we can support both versions from the same codebase, that's great too though. I just wouldn't want for anybody to spend a lot of time on this and for it just to be hard.

-Rocky Meza 2014年9月17日 下午8:40于 "Antoine Catton" notifications@github.com写道:

Thank you @deshipu https://github.com/deshipu for this pull request. You're really hunting bugs down!

This fixes the bug with the new version of pyscss but some of our users might be using an older version of pyScss. This is breaking as the tests show. Could you extend travis' test matrix to test with the old version of pyScss and the new one?

You might want to wrap your import in a try...except ImportError: # pyScss < version statement.

— Reply to this email directly or view it on GitHub https://github.com/fusionbox/django-pyscss/pull/20#issuecomment-55887208 .

deshipu commented 10 years ago

Sorry for not checking the tests, that was stupid of me.

I have nothing against having a new version of django-pyscss to support pyScss>=1.3, as long as it gets released in time to get into this release of OpenStack. The thing is, pyScss 1.3 has a bug fix that we need in order to be able to use Bootstrap 3.2.0. So now we have a choice: either upgrade both pyScss and Django-pyScss to versions that work with Bootstrap 3.2.0, or downgrade Bootstrap to 3.1.x. If possible, we would prefer the former, of course. We need to make the decision fast, as we are already in dependency freeze and any changes are going to affect the work of packagers, who already have a lot of work on their hands.

In case we choose to downgrade Bootstrap and stay with pyScss 1.2 and Django-pyScss 1.0.3, we would appreciate if you told us at which version you plan to break the compatibility, so that we can put an appropriate bound on our dependencies.

eevee commented 10 years ago

I don't know anything about OpenStack's release schedule, but would it help if I backported the fix into a pyScss 1.2.1?

eevee commented 10 years ago

Hokey alternative fix is in pyscss's 1.2.x branch. Bootstrap master compiles successfully.

rockymeza commented 10 years ago

Thanks @eevee

acatton commented 10 years ago

Duplicate #21?