search

fusionbox / django-pyscss

Makes it easier to use PyScss in Django
https://pypi.python.org/pypi/django-pyscss
BSD 2-Clause "Simplified" License
19 stars 13 forks source link

make tests succeed on Django-1.7 #25

Closed mrunge closed 9 years ago

mrunge commented 9 years ago

This more tiny patch makes at least OpenStack Horizon work for me with Django 1.6 and 1.7. Also fixes tests on Django-1.6 and Django-1.7

acatton commented 9 years ago

Released in 1.0.6

gavinwahl commented 9 years ago

Does this still support prefixes? https://docs.djangoproject.com/en/dev/ref/settings/#prefixes-optional

acatton commented 9 years ago

@gavinwahl I'm not sure to understand the question. According to the change, the goal is to handle a case where storage wouldn't have a prefix attribute that's all. Otherwise it seems backward comptiable.

As far as I know, we're testing prefixes in the tests. And all tests were passing when I merged. Or did I misunderstand your question?

gavinwahl commented 9 years ago

In django 1.6, the prefix is None if there isn't a prefix. Django 1.7 removed the prefix attribute and implemented it differently

acatton commented 9 years ago

https://github.com/fusionbox/django-pyscss/blob/master/tests/test_scss.py#L50 this test seems to pass.