search

fusionbox / django-pyscss

Makes it easier to use PyScss in Django
https://pypi.python.org/pypi/django-pyscss
BSD 2-Clause "Simplified" License
19 stars 13 forks source link

Inject Django's DEBUG setting into sass namespace as $debug #41

Open nolsto opened 9 years ago

nolsto commented 9 years ago

An idea from @rockymeza in #32.

rockymeza commented 9 years ago

Yay!

A couple quick questions:

  1. Would this be better done as an Extension? (That way we could opt-in/out of it).
  2. Should it be $DEBUG?

Release blocker: no docs.

rockymeza commented 9 years ago

Also, in the docs, we should probably leave a reminder that it's not a good idea to hide things that you aren't comfortable with people seeing, as that info will still be available in the HTML.

nolsto commented 9 years ago

Would this be better done as an Extension? (That way we could opt-in/out of it).

Good call. That avoids the kwarg fiddling this relies on now. Could do

# opt-in option
DjangoScssCompiler() # extensions=(DjangoExtension, CompassExtension)
DjangoScssCompiler(extensions=(DjangoDebugExtension. DjangoExtension, CompassExtension))

# opt-out option
DjangoScssCompiler() # extensions=(DjangoDebugExtension, DjangoExtension, CompassExtension)
DjangoScssCompiler(extensions=(DjangoExtension, CompassExtension))

Not sure as to which would be preferred. Thoughts?

Should it be $DEBUG?

Though it looks less like a typical sass variable, that would certainly make a more explicit connection with the Django setting.

rockymeza commented 9 years ago

I think opt-in might be better. We've got lots of people already using the system and we don't want to suddenly override their variables in any way.

Though it looks less like a typical sass variable, that would certainly make a more explicit connection with the Django setting.

lowercase then

gavinwahl commented 9 years ago

Do you guys actually have a use for this?

rockymeza commented 9 years ago

I don't yet.

-rocky

On Sat, Jul 25, 2015 at 1:01 AM, Gavin Wahl notifications@github.com wrote:

Do you guys actually have a use for this?

— Reply to this email directly or view it on GitHub https://github.com/fusionbox/django-pyscss/pull/41#issuecomment-124579546 .

rockymeza commented 8 years ago

maybe better as docs?