search

fusionbox / django-pyscss

Makes it easier to use PyScss in Django
https://pypi.python.org/pypi/django-pyscss
BSD 2-Clause "Simplified" License
19 stars 13 forks source link

Python 3 fixes #7

Closed wojas closed 9 years ago

wojas commented 10 years ago

Relates to issue #1 (Python 3 support)

Made setup.py work with Python 3 (convert binary to text).

In Python 3 the SCSS source code must be decoded from binary to text before processing. The latest compressor passes a charset argument to our filter, which will be used. If not passed, it will default to utf-8.

Note that Python 3 support currently depends on the latest (master) compressor and a pyScss with this fix incorporated (pull request submitted): https://github.com/wojas/pyScss/commit/e4cf419509f3c568c108c3196e2fda50bcc37536

NOTE: Tests related to the sprites fail for me, both on python 2.7 and 3.4. The hash is different from what's expected.

rockymeza commented 10 years ago

Thanks for looking into this @wojas! We've been waiting on django-compressor to support Python3, I guess things are coming together on their end, so now the onus is on us too. I've left a couple of comments and I will look into the failing sprite test that you mentioned.

rockymeza commented 10 years ago

@wojas, I'm not getting any bugs, can you post the error message here?

Thanks

rockymeza commented 9 years ago

fixed with #31!

Thanks for getting this started @wojas