search

fusioncharts / angular-fusioncharts

Angular Component for FusionCharts JavaScript Charting Library
https://fusioncharts.github.io/angular-fusioncharts/#/ex1
Other
55 stars 37 forks source link

Does not work with angular 14 #153

Open Gillardo opened 2 years ago

Gillardo commented 2 years ago

Follow the steps on the readme file but use angular 14 and you get this error when trying to run ng serve

image

Gillardo commented 2 years ago

Here is a sample project, just run npm install and then ng serve and you should replicate the problem

fusion-charts.zip

spac-valentin commented 2 years ago

Is there a plan to start supporting angular 14 soon?

hebus commented 2 years ago

As a workaround, you can put the "angular-fusioncharts"'s source code inside you Angular 14 project... And all should works fine

epiphanizer commented 2 years ago

@hebus Your workaround got it compiling, but actual loading of charts fails with ERROR TypeError: Cannot read properties of null (reading 'firstCreatePass') at providersResolver (core.mjs:21149:13)

Any thoughts? Should I just use 13?

hebus commented 2 years ago

Hello @epiphanizer , Here a stackblitz link: https://stackblitz.com/edit/angular-ivy-32bzyf

Don't worry, if does not work online, just download the source code and test it in local. This is how we have fixed Angular 14 compilation issues

ajeet2017 commented 1 year ago

@hebus in angular 14 got compile successfully. but while load page throw error. ypeError: Cannot read properties of null (reading 'firstCreatePass'). Is it version issue? how can I resolve.

jerone commented 1 year ago

@fusioncharts We are paying customers and our applications are being held back by this one package lacking support for newer versions of Angular.

This discussion also started with Angular 12, then with version 13 and now with 14.

For the previous versions, the upgrade was possible by forcing the upgrade. Now with version 14 of Angular, this is not possible anymore, and blocking exceptions are thrown.

Angular 14 is out for 4+ months now. Please hold an higher release schedule for supporting new versions of Angular.

jerone commented 1 year ago

@fusioncharts I've created #154 to upgrade to Angular 14.

jprinsloo commented 1 year ago

@fusioncharts please merge #154 and make a new package for us to use.

jerone commented 1 year ago

And now we are multiple version behind again, with Angular 15 just released.

I don't know why I pay for this product !!!

abishek commented 1 year ago

When I spoke to their support, they didn't even have an ETA, and their claim was - this is an open-source project, so we cannot expect them to deliver or support. unfortunately, they don't seem to know why or how open-source works: they are not even open to merging community patches. Unfortunately, moving away is not a simple decision either :-(

@jerone would it be possible to publish your patched version as an unofficial package?

jerone commented 1 year ago

The argument about being an open-source project is confusing. They maintain this repo, plus they mention support for Angular multiple times on their website. 1. 2.

I'll contact them too, asking to prioritize this blocking issue.

[..] they are not even open to merging community patches.

Exactly, the work is already done #154 (if they confirm everything is working correctly).

@jerone would it be possible to publish your patched version as an unofficial package?

I have to think about this and discuss this internally, as I forked this repo from my companies org. I try to stay away from publishing clones, because I cannot and will not give support if we unofficially publish it.

Franccescalee commented 1 year ago

Same issue trying to upgrade my app to Angular 14. We only purchased our license due to the fact that they said it "had support for Angular".

jerone commented 1 year ago

@Franccescalee commented on Nov 23, 2022, 8:43 PM GMT+1:

@jerone can you add someone as a reviewer? It looks like it would let me approve which is strange. If it is an open-source project who would we reach out to publish your updates?

No, this is impossible, I'm not an admin, member or a collaborator of this repository.

Best thing is to upvote this issue, upvote the referenced PR and contact Fusioncharts.

jerone commented 1 year ago

Some activity happening:

unspike commented 1 year ago

@fusioncharts We are paying customers and our applications are being held back by this one package lacking support for newer versions of Angular.

This discussion also started with Angular 12, then with version 13 and now with 14.

For the previous versions, the upgrade was possible by forcing the upgrade. Now with version 14 of Angular, this is not possible anymore, and blocking exceptions are thrown.

Angular 14 is out for 4+ months now. Please hold an higher release schedule for supporting new versions of Angular.

@jerone how did u solved issue on angular 12? I have Cannot read properties of null (reading 'firstCreatePass') issue (on prod only, and only on hosted machine, locally 'prod' build also works, and can't find the solution

jerone commented 1 year ago

@unspike I didn't.

This story is about Angular 14 & 15 support.

unspike commented 1 year ago

@jerone yeah, but u said

For the previous versions, the upgrade was possible by forcing the upgrade.

can you please clarify what do u mean by that.

jerone commented 1 year ago

@unspike ng update --force ...

AdiSilagy commented 1 year ago

We are also paying customers and we are forced to upgrade to Angular 14. Did anyone managed to work around this issue?

ghost commented 1 year ago

What a lamentable business. They need to remediate this things to avoid paying for a license for something that you cannot upgrade.

Franccescalee commented 1 year ago

We are also paying customers and we are forced to upgrade to Angular 14. Did anyone managed to work around this issue?

@AdiSilagy We had to clone the repository and upgrade it ourselves. Then published to a private NPM package.

yuricamara commented 1 year ago

@Franccescalee , how did you upgrade it? Please, let us know.

Franccescalee commented 1 year ago

@yuricamara I think I just changed the angular packages in the package.json to go to 14.x before I did an npm install. I compared what was in there to what I have in my app as well. Then built/packed/published. I don't remember needing to make any changes to the code.

AyanBhadury commented 1 year ago

Hello,

The latest version of angular-fusioncharts has just been released that is angular-fusioncharts 4.0.3 . This version supports angular version till the latest one (15). If you want you can upgrade the angular version and test your application.

Here is the npm link : https://www.npmjs.com/package/angular-fusioncharts/v/4.0.3

Demo - https://github.com/AyanBhadury/angular-fusioncharts-sample

jerone commented 1 year ago

Super great news. I'll give it a try soon. 🎉

Can you please create an CHANGELOG to keep track of the changes. Preferably via the "Releases" tab. Many corporation need to track the changes.

Are there for example no breaking changes? Upgrade guide?

But more important, Angular 16 is less then 1 month away ("week of 2023-05-01").

https://angular.io/guide/releases#release-schedule Please add support for Angular 16 ASAP !!!

AyanBhadury commented 1 year ago

Sorry I don't have the permission, may be create a ticket to support@fusioncharts.com and request them to add it.