Angular 14. Fixes #153 - Githubissues

jerone commented 1 year ago

This PR upgrades the whole project to support Angular 14.

Fixes #153 & #137 & #140 and probably many others!

Upgrade to Angular 14.
Allowed Angular 14 in dependencies range. Loosened other dependencies too (@types/fusioncharts, RxJS, Zone.js). Not good to pin those so hard.
Converted (unsupported) angular-cli.json to angular.json.
Fixed issues with rollup config and bulding.
Updated version to 14 to keep in sync with Angular versioning.
Updated dist folder. Why does this needs to be committed?

I got these change working in our companies project, but this requires full testing on all supported Angular versions, and probably even more clean up. Why is there no automated testing setup?

Also, please don't publish the whole project to NPM, only the dist files are enough: https://unpkg.com/browse/angular-fusioncharts@4.0.0/

paksydavid commented 1 year ago

Many thanks. 👍🏽

Would be great if this PR would receive some maintainer attention.

jerone commented 1 year ago

Apparently FusionCharts is doing their own upgrade, which is good news (finally). Aldo some communication would be nice.

It also looks like they focus on Angular 15, which is already out for 2 months.

For that reason and with all these merge conflicts, I'm going to close this PR.

I do hope their upgrade is better then their review process; https://github.com/fusioncharts/angular-fusioncharts/commit/1e29b5c37041243ddd385abe938ca2cb1cc353df#r97467805 and a few other weird changes. I hope to be positively surprised.

fusioncharts / angular-fusioncharts

Angular 14. Fixes #153 #154