search

fusioncharts / angularjs-fusioncharts

AngularJS Directive for FusionCharts JavaScript Charting Library (for Angular 1.x)
https://fusioncharts.github.io/angularjs-fusioncharts/
MIT License
111 stars 101 forks source link

Disposing logic #46

Closed jasmh closed 6 years ago

jasmh commented 6 years ago

Why isn't this merged?

https://github.com/fusioncharts/angular-fusioncharts/pull/33

I concluded that I need this exact change in my code and added it before I even looked at the issues and found this PR. It prevents memory leaks and I think it sometimes may prevent unexpected errors like 'nodeType is null' as the chart is not disposed when the DOM element is removed.

rousan commented 6 years ago

Hi @jasmh, The problem described in #33 PR is already resolved and will be available in next patch version soon, so we should close this PR as well as this issue. Thanks.

jasmh commented 6 years ago

Would you care to elaborate a bit more? I don't see any new commits to angular-fusioncharts. Is it handled internally by fusioncharts? If yes, in which version?

rousan commented 6 years ago

Hi @jasmh We resolved this issue and the patch version for this issue will be released soon.

ashok1994 commented 6 years ago

@jasmh The pull request is merged now , will be available in next patch release 4.0.3. Closing for now .