search

fusioninventory / fusioninventory-for-glpi

FusionInventory plugin for GLPI
http://www.FusionInventory.org/
GNU Affero General Public License v3.0
362 stars 150 forks source link

Wrong serial number for HP desktop #2508

Open okvok opened 6 years ago

okvok commented 6 years ago

We've faced with an issue of wrong serial number. A desktop already in GLPI computer assets with correct serial number SGH327SZYD. Agent 2.3.20 scanning the desktop properly as well: image image

BUT on the server site GLPI 9.2.1 or Fusioninventory plugin 9.2+1.0 change it to GH327SZYD and create a new object in computer assets with a wrong serial number. It loses the first serial number symbol. image image

Could anybody help us with this issue? Please!

ddurieux commented 6 years ago

It's because the real serial name (on the sticky label) has not the S (the first letter) so we remove it

okvok commented 6 years ago

no. It has S on the sticky label. The HP serial number contain 10 symbols.

okvok commented 6 years ago

image

okvok commented 6 years ago

Please fix this BUG.

okvok commented 6 years ago

I solved the issue! Please see below: image

I think it would be better to exclude this code from the future plugin releases. Thank you!

ddurieux commented 6 years ago

Yes, but be careful if you have some computer in this case...

okvok commented 6 years ago

Yes, we have. But why did you make this patch for HP? I suppose this is wrong patch and it should be excluded from the future releases. I provided you the photo of the sticker with the serial number and you can see S at the beginning of the serial number. May be you will speak to other FI-plugin developers about it?

ddurieux commented 6 years ago

Because in old computers the serial number in the BIOS not same than sticker and so have the S un prefix. Seems they had fix it, but not really simple to manage the old and the new serial number depend on age of the computer

okvok commented 6 years ago

what kind of information should I provide you for correct working either types of computers?

okvok commented 6 years ago

IMHO it must be working for all of them!

AnaelMobilia commented 6 years ago

@ddurieux Really hard to known... Maybe a display as (S)xxxx ? with a popup over the S ?

Regards, Anael

ddurieux commented 6 years ago

Perhaps related with number of characters, must check that (can take some times)