fusionjs / browser-tests

Example app for cross-browser testing
MIT License
6 stars 8 forks source link

Add test that catches issue with chunk preload instrumentation #108

Closed ganemone closed 6 years ago

ganemone commented 6 years ago

This test is required to make sure we verify the client side js is running without error

old-fusion-bot[bot] commented 6 years ago

Found TODOs without GitHub issues: https://github.com/fusionjs/browser-tests/blob/221aa7a18ae95ddc1cf7fcc895f62699b9cabde2/src/test/browser/index.js#L25

old-fusion-bot[bot] commented 6 years ago

Found TODOs without GitHub issues: https://github.com/fusionjs/browser-tests/blob/392017b407116189b02e1f4ad4d08ca3e260fbac/src/test/browser/index.js#L25

KevinGrandon commented 6 years ago

A little confused as to why this was landed in a failing state?

Edit - ah I see now that flow was perma-failing, and that there's still some flakiness in sauce/selenium. (We should still wait for green before merging ideally)