search

fusionjs / fusion-cli

Migrated to https://github.com/fusionjs/fusionjs
MIT License
140 stars 37 forks source link

Improve tests #699

Closed lhorie closed 5 years ago

lhorie commented 5 years ago

Fix gql test regressions Migrate i18n integration tests to fusion-cli

lhorie commented 5 years ago

Yeah, I'm moving them out of fusion-plugin-i18n-react to remove a cyclical dependency between fusion-plugin-i18n-react and fusion-cli. This is needed to unblock putting these two packages in a monorepo

lhorie commented 5 years ago

Note: I found another integration test in the other test file in fusion-plugin-i18n-react, so I moved it into here as well.

lhorie commented 5 years ago

Yeah, I think we need to revisit the testing strategy here at some point. There's a bunch of stuff that probably should live in other packages, and also a bunch of tests that leave fixture files in weird states when tests throw or are aborted. Some refactoring targeting those issues will probably allow us to parallelize tests across CPUs to improve test times as well.

For now, since the tests are merely migrated from one repo to the other, release verification will eventually catch issues. In any case, this migration is low risk because we haven't done many changes to fusion-plugin-i18n-react lately anyways.

old-fusion-bot[bot] commented 5 years ago

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1463