search

fusionjs / fusion-cli

Migrated to https://github.com/fusionjs/fusionjs
MIT License
140 stars 37 forks source link

Fix jest test chunking #728

Closed KevinGrandon closed 5 years ago

KevinGrandon commented 5 years ago

Currently it seems we're only running a subset of fusion-cli tests in CI. I believe this is because testMatch is not a valid jest CLI flag, while testPathPattern is. Use testPathPattern and convert globs to regex.

This seems to have been broken in the jest update here: https://github.com/fusionjs/fusion-cli/commit/d84c834f805fcdb32caf619eca24a326270d6974

I looked through the Jest changelog but did not see references to removing this flag. It could be that this flag was undocumented, and we just got lucky that it worked.

Current output on master for first test chunk: image

old-fusion-bot[bot] commented 5 years ago

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1694