search

fusionjs / fusion-cli

Migrated to https://github.com/fusionjs/fusionjs
MIT License
140 stars 37 forks source link

Fix EventEmitter leak in dev-runtime #752

Closed cdlewis closed 5 years ago

cdlewis commented 5 years ago

Lifecycle registered two event listeners using once. Only one would unregister itself, leading to us leaking emitters. This could potentially bring down the Fusion server as calls to lifecycle.wait() would hang.

micburks commented 5 years ago

!merge

old-fusion-bot[bot] commented 5 years ago

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1846