search

fusionjs / fusion-core

Migrated to https://github.com/fusionjs/fusionjs
MIT License
630 stars 45 forks source link

Resolve timing.end on errored requests #333

Closed ganemone closed 6 years ago

ganemone commented 6 years ago

We should always resolve timing.end, even if the request errors (via ctx.throw for example).

codecov[bot] commented 6 years ago

Codecov Report

Merging #333 into master will increase coverage by 0.33%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   93.34%   93.67%   +0.33%     
==========================================
  Files          18       18              
  Lines         436      443       +7     
  Branches       85       86       +1     
==========================================
+ Hits          407      415       +8     
+ Misses         16       15       -1     
  Partials       13       13
Impacted Files Coverage Δ
src/plugins/timing.js 95.23% <100%> (+0.95%) :arrow_up:
src/compose.js 66.66% <0%> (+5.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83f7a0f...1f40119. Read the comment docs.