search

fusionjs / fusion-core

Migrated to https://github.com/fusionjs/fusionjs
MIT License
630 stars 45 forks source link

Remove fusion-cli peer dep #345

Closed lhorie closed 6 years ago

lhorie commented 6 years ago

fusion-cli doesn't appear to be actually used anywhere in fusion-core

This PR removes it from package.json.

Rationale: fusion-cli depends on fusion-core, so we want to avoid having fusion-core cyclically depend on fusion-cli in order to allow the two to co-exist in a monorepo where fusion co-dependencies are linked together via symlinks or similar mechanisms. Cyclical dependencies cause problems for tooling that relies on file system traversal, and need to be avoided.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a58da5b). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #345   +/-   ##
=========================================
  Coverage          ?   93.17%           
=========================================
  Files             ?       18           
  Lines             ?      454           
  Branches          ?       89           
=========================================
  Hits              ?      423           
  Misses            ?       17           
  Partials          ?       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a58da5b...e44cc23. Read the comment docs.