search

fusionjs / fusion-core

Migrated to https://github.com/fusionjs/fusionjs
MIT License
630 stars 45 forks source link

Add error message to catch a plugin being added as a middleware #349

Open rajeshsegu opened 5 years ago

lhorie commented 5 years ago

Need to fix flow error. Also, this is not greenkeeping. I'd say bugfix might be a more appropriate tag.

@KevinGrandon I think it's ok to add runtime checks for these, at least for now. We've had a few cases of post-migration code throwing bad errors and wasting people's time that could've been avoided by surfacing errors such as this. Also, the test suite already has a lot of tests similar to this one.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fb86e7f). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #349   +/-   ##
=========================================
  Coverage          ?   93.23%           
=========================================
  Files             ?       18           
  Lines             ?      458           
  Branches          ?       92           
=========================================
  Hits              ?      427           
  Misses            ?       17           
  Partials          ?       14
Impacted Files Coverage Δ
src/base-app.js 90.11% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb86e7f...30aae8c. Read the comment docs.

rajeshsegu commented 5 years ago

@KevinGrandon @lhorie please do review ( updated tag to bugfix and flow passes )