search

fusionjs / fusion-plugin-connected-react-router

Migrated to https://github.com/fusionjs/fusionjs
MIT License
2 stars 9 forks source link

Fix issue #28: cannot read property 'pathname' of undefined #29

Open mrmuhammadali opened 5 years ago

mrmuhammadali commented 5 years ago

I was getting errors while configuring the plugin, I opened an issue so I thought why not I solve it myself. So here are the steps I did:

  1. Created flatCombineReducers utility which merges reducers without need of a key like combineReducers does.
  2. Created a routerReducer which is required by connected-router-redux
  3. Merged router reducer and root reducer, i.e. routerReducer and reducer
  4. Replaced store reducer with the merged reducer.
CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

mrmuhammadali commented 5 years ago

@KevinGrandon Can you look into this PR?

KevinGrandon commented 5 years ago

Thanks for the PR. We really want to get this landed, but can't quite yet due to the following:

We are working on a roadmap for React 15, and will revisit this as soon as we have React 15 deprecation planned.