search

fusionjs / fusion-plugin-rpc-redux-react

Migrated to https://github.com/fusionjs/fusionjs
MIT License
4 stars 17 forks source link

Import and export ActionType from dependency fusion-rpc-redux ^1.4.0 #181

Closed hugoe29 closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@82d878b). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage          ?   93.33%           
=========================================
  Files             ?        2           
  Lines             ?       30           
  Branches          ?        5           
=========================================
  Hits              ?       28           
  Misses            ?        0           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82d878b...3b7ded3. Read the comment docs.

lhorie commented 5 years ago

Looks good to me! Thanks @hugoe29 !

lhorie commented 5 years ago

Oh, the export also needed to be changed. I went ahead and made the adjustment

hugoe29 commented 5 years ago

Thanks @lhorie It seems it is just waiting for the reviewer approval.

old-fusion-bot[bot] commented 5 years ago

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1655