search

fusionjs / fusion-plugin-service-worker

Migrated to https://github.com/fusionjs/fusionjs
MIT License
6 stars 8 forks source link

Refactor for DI FusionJS #20

Closed angus-c closed 6 years ago

angus-c commented 6 years ago

Resolves #21

old-fusion-bot[bot] commented 6 years ago

Please add one of the following required labels:

old-fusion-bot[bot] commented 6 years ago

Found TODOs without GitHub issues: https://github.com/fusionjs/fusion-plugin-service-worker/blob/e613093daec7eedcad948e87146a5b96d7045521/src/server.js#L7 https://github.com/fusionjs/fusion-plugin-service-worker/blob/e613093daec7eedcad948e87146a5b96d7045521/src/server.js#L10 https://github.com/fusionjs/fusion-plugin-service-worker/blob/e613093daec7eedcad948e87146a5b96d7045521/src/server.js#L20 https://github.com/fusionjs/fusion-plugin-service-worker/blob/e613093daec7eedcad948e87146a5b96d7045521/src/server.js#L27 https://github.com/fusionjs/fusion-plugin-service-worker/blob/e613093daec7eedcad948e87146a5b96d7045521/src/server.js#L32 https://github.com/fusionjs/fusion-plugin-service-worker/blob/e613093daec7eedcad948e87146a5b96d7045521/src/types.js#L15

old-fusion-bot[bot] commented 6 years ago

Please add one of the following required labels:

old-fusion-bot[bot] commented 6 years ago

Please add one of the following required labels:

old-fusion-bot[bot] commented 6 years ago

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/710

old-fusion-bot[bot] commented 6 years ago

https://github.com/fusionjs/fusion-plugin-service-worker/compare/fusionjs:master...fusionjs:initial

old-fusion-bot[bot] commented 6 years ago

Please add one of the following required labels:

old-fusion-bot[bot] commented 6 years ago

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/711

old-fusion-bot[bot] commented 6 years ago

https://github.com/fusionjs/fusion-plugin-service-worker/compare/fusionjs:master...fusionjs:initial

old-fusion-bot[bot] commented 6 years ago

Please add one of the following required labels:

KevinGrandon commented 6 years ago

Something weird happened with the history here, not sure why it's showing all of the previous commits on master? I bet if we rebase against upstream/master, you could probably drop all of the previous commits?

angus-c commented 6 years ago

Closing, too far gone to rebase against master