search

fusionjs / fusion-plugin-service-worker

Migrated to https://github.com/fusionjs/fusionjs
MIT License
6 stars 8 forks source link

Add logger token and more robust browser test #88

Closed angus-c closed 5 years ago

angus-c commented 5 years ago

Timestamp was added in fusion-cli peer release which I've added as a peer dependency. This means dev works with service worker so I can remove warning note in README

AlexMSmithCA commented 5 years ago

Just curious, does have an outdated version of fusion-cli break usage of this plugin? We have lots of warnings for unmet peer dependencies today so this one may get drowned out in the noise.

angus-c commented 5 years ago

https://github.com/fusionjs/fusion-plugin-service-worker/pull/88#issuecomment-458730883

It wouldn't break it, but would potentially make the code sticky in dev mode (cache over-zealously)

AlexMSmithCA commented 5 years ago

LGTM. Thanks for updates!