Closed qqingvarqq closed 5 years ago
Closed by https://github.com/fusionjs/fusionjs/commit/c65f4902ae1ce02c07495ac5270856cb433a0e02
As for moving all those dependencies, I'm not entirely sure but I think there may be a technical constraint around doing that. More importantly though, that would put the onus on Fusion maintainers to release a new config every time any of those deps change. I think it's much preferable for engineers to control their specific eslint plugin versions
When we create a new fusion app through script
yarn create fusion-app
. This new app has, lint script, but to run this script you need to add lots of dev dependencies.To fix this issue we can add those dependencies to package.json in the template. I saw that in other fusion plugins where you use
eslint-config-fusion
you did this.But I propose a better solution, in
eslint-config-fusion
move those dependencies from peer to actual dependencies. It gives us.eslint-config-fusion
.eslint-config-fusion
and everything works.But if we apply changes, those who use
eslint-config-fusion
with these changes should somehow know that now they can delete those dependencies from his package.json.I would make PR for this issue If project members agree with one of the solutions.