Clean up and refactor codebase - Githubissues

fusor / ocp-velero-plugin

Apache License 2.0

1 stars 6 forks source link

Clean up and refactor codebase #9

Open dymurray opened 5 years ago

dymurray commented 5 years ago

[x] There are many instances of duplicated code across backup/restore in the same package that can be cleaned up. An example: https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/common/backup.go#L49 https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/common/restore.go#L49
[x] A lot of backup code is doing nothing... would be good to go through and delete whatever we are not using: https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/route/backup.go https://github.com/fusor/ocp-velero-plugin/blob/master/velero-plugins/buildconfig/backup.go
[x] Remove all copyrights that refer to heptio's contributors

alexander-demicev commented 5 years ago

I will take this issue

alexander-demicev commented 5 years ago

https://github.com/fusor/ocp-velero-plugin/pull/12 - Removed copyrights

alexander-demicev commented 5 years ago

https://github.com/fusor/ocp-velero-plugin/pull/19 - Removed unused code

alexander-demicev commented 5 years ago

https://github.com/fusor/ocp-velero-plugin/pull/23