search

fussybeaver / bollard

Docker daemon API in Rust
Apache License 2.0
858 stars 131 forks source link

Omit `changes` query parameter in `CreateImageOptions` if `Vec` is empty #353

Closed fmckeogh closed 9 months ago

fmckeogh commented 9 months ago

Closes #352

fussybeaver commented 9 months ago

I'm not on my desktop at the moment, but looks good... Would also be good to get a test case around the wasm use case that you mentioned.

fmckeogh commented 9 months ago

I'm not on my desktop at the moment, but looks good... Would also be good to get a test case around the wasm use case that you mentioned.

Sure thing, I'll write one now (making sure it fails without the fix)

fmckeogh commented 9 months ago

Done

fussybeaver commented 9 months ago

Thanks, looks good, happy to merge if we can get one assert in there