search

fussybeaver / bollard

Docker daemon API in Rust
Apache License 2.0
912 stars 134 forks source link

feat: Add connect_with_defaults #370

Closed jalaziz closed 9 months ago

jalaziz commented 10 months ago

Add connect_with_defaults function that intelligently selects the best connection method to use based on the DOCKER_HOST and DOCKER_TLS_VERIFY environment variables. This mimics the logic of the Docker CLI.

Fixes #310

jalaziz commented 10 months ago

I have not tested this yet. Hope to do that sometime this coming week.

fussybeaver commented 10 months ago

Thanks for the contribution, I'm away from my computer for a week, but looking through the PR it looks good.

Maybe we can figure out how to test each branch somehow.

jalaziz commented 10 months ago

I think the best way to test the branches is to use the docker DinD image to launch different docker daemons and attempt to connect.

I'll try to set it up this weekend if I can find some time.

fussybeaver commented 9 months ago

Adding tests in #373

jalaziz commented 9 months ago

Thank you and sorry for not getting to the tests myself 🙏🏼

jalaziz commented 9 months ago

Hate to be this person, but will there be a new release in the near future?

fussybeaver commented 9 months ago

Yeah, we're very close. My only reservation is that we now need to peg to a GitHub revision of the hyperlocal dependency.