search

fussybeaver / bollard

Docker daemon API in Rust
Apache License 2.0
911 stars 134 forks source link

Docker::connect_with_transport #458

Closed izissise closed 2 months ago

izissise commented 3 months ago

Hello,

I'd like to connect to a docker daemon with tls certificate, but the certificate are never stored on the filesystem client side. connect_with_ssl only take Path for keys.

Would it be possible to have a constructor that take directly a Transport so a user can set it up themselve. An alternative would be to able to pass a rustls::ClientConfig.

I'm willing to contribute this, what do you think?

Thanks, Hugues

Edit: I think this could also make it possible to tunnel through ssh https://github.com/fussybeaver/bollard/issues/244

fussybeaver commented 3 months ago

Yes, I'm definitely interested. There was some conversation recently around request customisation ( https://github.com/fussybeaver/bollard/issues/395#issuecomment-2245054968 and https://github.com/fussybeaver/bollard/issues/436 ), so it would be interesting to see if this implementation can be used as a template to solve that problem too.

fussybeaver commented 2 months ago

@izissise can we close this, due to #459 ?

izissise commented 2 months ago

Yes all good for me :)