fustom / ariston-remotethermo-home-assistant-v3

Ariston NET remotethermo integration for Home Assistant based on API
MIT License
144 stars 36 forks source link

enable current temperature sensor on Evo2 #328

Closed maxlaverse closed 1 month ago

maxlaverse commented 4 months ago

I modified the custom component to display a Current Temperature sensor for my Evo2 boilers a couple of weeks ago. Was there any reason from not having this sensor enabled for this device ? Else maybe we could bring that change upstream ?

ariston.discover() returns (amongst other things) 'wheType': 6, 'wheModelType': 22

Thanks!

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

fustom commented 2 months ago

https://github.com/fustom/ariston-remotethermo-home-assistant-v3/issues/224#issuecomment-1874205762

maxlaverse commented 2 months ago

Thanks @fustom! That's what I actually started with, but then I realized I could make this temperature appear in the out-of-the-box device card in the main view of Home Assistant, which is why I decide to go for the patch. Don't hesitate to close the PR if you think it's not worth it, e.g. because we need to figure out if all Evo2 models actually support it.

maxlaverse commented 1 month ago

Closing to keep my list of opened PR clean!