futapi / fut

fut is a simple library for managing Fifa 19 Ultimate Team.
GNU General Public License v3.0
317 stars 138 forks source link

FUT19 #422

Closed derSoerrn95 closed 6 years ago

derSoerrn95 commented 6 years ago

Hey,

I did some changed for FUT19. For me this is working on ps4, but it should work on other platforms as well - but without engagement.

EA disabled the phishing token parameter for requests after the signing in. So I think we need to observe it.

codecov-io commented 6 years ago

Codecov Report

Merging #422 into master will decrease coverage by 8.92%. The diff coverage is 29.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   57.89%   48.96%   -8.93%     
==========================================
  Files           8        9       +1     
  Lines         342      484     +142     
  Branches       29       46      +17     
==========================================
+ Hits          198      237      +39     
- Misses        141      244     +103     
  Partials        3        3
Impacted Files Coverage Δ
fut/config.py 100% <ø> (ø) :arrow_up:
fut/exceptions.py 82.14% <100%> (+0.66%) :arrow_up:
fut/urls.py 75% <100%> (+3.57%) :arrow_up:
fut/pin.py 15.46% <12.9%> (-4.54%) :arrow_down:
fut/stats.py 30.76% <30.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c703f39...52f87b5. Read the comment docs.

oczkers commented 6 years ago

Thats very big pr and nice work with stats file, thanks!