search

futapi / fut

fut is a simple library for managing Fifa 19 Ultimate Team.
GNU General Public License v3.0
317 stars 138 forks source link

Fix query params 'league' and 'nation' used in Core.club() #452

Open yuesong opened 5 years ago

yuesong commented 5 years ago

This PR fixes query param names used in Core.club() that don't work for FUT 19. An example API call captured in Chrome looks like this:

https://utas.external.s2.fut.ea.com/ut/game/fifa19/club?sort=asc&type=player&level=bronze&team=650&league=10&nation=34&position=RB&start=0&count=91&_=1548437016376

Note the correct league and nation params in the above URL.

codecov-io commented 5 years ago

Codecov Report

Merging #452 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   51.72%   51.72%           
=======================================
  Files           9        9           
  Lines         464      464           
  Branches       39       39           
=======================================
  Hits          240      240           
  Misses        221      221           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3792c9e...9aee911. Read the comment docs.

jimmyyou commented 5 years ago

I have the same observation. Looking forward to merging this PR.