Default to react-icons, fallback to material

futil-js / contexture-react

React components for building contexture interfaces

https://smartprocure.github.io/contexture-react

MIT License

6 stars 4 forks source link

Default to react-icons, fallback to material #475

Closed Akrion closed 3 years ago

Akrion commented 3 years ago

Defaults to react-icons
Keeps material-icons support just in case

decrapifier commented 3 years ago

	Warnings
:warning:	The README has not been updated. Please update the README.

	Messages
:book:	Could not find any browser results.

Generated by :no_entry_sign: dangerJS against 8f7687cc89df2a338ddee123f572ba98388e4970

stellarhoof commented 3 years ago

I thought we were going to use theming to provide the needed icons. Why take a dependency on react-icons?

Akrion commented 3 years ago

I thought we were going to use theming to provide the needed icons. Why take a dependency on react-icons?

I must have missed the memo. Let's discuss this after the standup so I can catch up.

re1ro commented 3 years ago

@Akrion I though we want to do this on spark side and pass new Icon component through the contexture-react theme. We are moving out from GreyVest, so no need to change anything there

Akrion commented 3 years ago

Closing