futil-js / contexture-react

React components for building contexture interfaces
https://smartprocure.github.io/contexture-react
MIT License
6 stars 4 forks source link

add loader to TagsQuery component #493

Closed vstlouis closed 3 years ago

vstlouis commented 3 years ago

This adds a spinner to the TagsQuery component. The loader shows when the node is updating. Storybook was also added to show a loading TabQuery. Closes https://github.com/smartprocure/spark/issues/10086

Loading Tabs Screen Shot 2021-04-20 at 8 42 47 PM

Storybook Loading Tags (Note that this is either pulled as a prop, from the theme, or the default Loader (Which this is currently doing which is why it looks different) Screen Shot 2021-04-20 at 9 05 13 PM

decrapifier commented 3 years ago
Warnings
:warning: The README has not been updated. Please update the README.
:warning: Branch being merged does not follow [Git Flow](http://nvie.com/posts/a-successful-git-branching-model/)
:warning: :exclamation: This PR is BIG (+4143 -3056) Please keep it below 500 net changes
Messages
:book: Could not find any browser results.

Generated by :no_entry_sign: dangerJS against 7a84117c38162b5236a3f16cee24b52aecf79284

stellarhoof commented 3 years ago

That blue on green looks awful. @daedalus28 Do we now have to come up with an API to change the loader color?

Also the spinner would look better a bit smaller.

daedalus28 commented 3 years ago

This is stale and no longer relevant