Introduce addTags - Githubissues

futil-js / contexture-react

React components for building contexture interfaces

https://smartprocure.github.io/contexture-react

MIT License

6 stars 4 forks source link

Introduce addTags #496

Closed Akrion closed 3 years ago

Akrion commented 3 years ago

The issue identified by @daedalus28 recently is that we call the tree.mutate on every single tag when someone does copy/paste of 100K tags. We limit to only 100 now ... but we still call tree.mutate 100 times.

Fix the splitCommas not being properly passed down from TagsQuery to TagsInput
Refactor the logic so that we now have addTags method which adds array
Refactor the common logic into utils so that the ExpandableTagsInput also uses it

decrapifier commented 3 years ago

	Warnings
:warning:	The README has not been updated. Please update the README.

	Messages
:book:	Could not find any browser results.

Generated by :no_entry_sign: dangerJS against d1382bd42f22d4bfd6f5a4aaffbfda48f30d6085

Akrion commented 3 years ago

I think we also need to modify the expandable tags input

I also updated that as well as refactored the common fns.