[feature] TagsQuery: making TagsQuery based on ExpandableTagsQuery

futil-js / contexture-react

React components for building contexture interfaces

MIT License

6 stars 4 forks source link

Closed re1ro closed 3 years ago

re1ro commented 3 years ago

[x] TagsQuery: making TagsQuery based on ExpandableTagsQuery
[x] Refactor: old TagsQuery became a part of ExpandableTagsQuery. So new TagsQuery and TagsQuerySearchBar are thin wrappers around ExpandableTagsQuery

decrapifier commented 3 years ago

	Warnings
:warning:	The README has not been updated. Please update the README.
:warning:	Branch being merged does not follow [Git Flow](http://nvie.com/posts/a-successful-git-branching-model/)

	Messages
:book:	Could not find any browser results.

Generated by :no_entry_sign: dangerJS against 34f2fca1374fcfbbb84c7a3886ada1bea6390a53

stellarhoof commented 3 years ago

@rma4ok Do we still need this OutsideClickHandler? Actually it seems like TagsQuerySearchBar could use TagsQuery now?

re1ro commented 3 years ago

@stellarhoof

OutsideClickHandler is used to collapse tags into one line when it gets unfocused.
That's exactly what happened, old TagsQuery became a part of ExpandableTagsQuery. So new TagsQuery and TagsQuerySearchBar are thin wrappers around ExpandableTagsQuery