futil-js / contexture-react

React components for building contexture interfaces
https://smartprocure.github.io/contexture-react
MIT License
6 stars 4 forks source link

Storybook V6 #517

Closed vstlouis closed 3 years ago

vstlouis commented 3 years ago

Upgrade storybook to the latest version

Closes https://github.com/smartprocure/spark/issues/11247

decrapifier commented 3 years ago
Warnings
:warning: The README has not been updated. Please update the README.
:warning: Branch being merged does not follow [Git Flow](http://nvie.com/posts/a-successful-git-branching-model/)
:warning: :exclamation: This PR is BIG (+28896 -20780) Please keep it below 500 net changes
Messages
:book: Could not find any browser results.

Generated by :no_entry_sign: dangerJS against c8f2e89941b7f951b88982f6808e082656a82da6

stellarhoof commented 3 years ago

There's something weird going on with the formatting in this PR

rudolph9 commented 3 years ago

I think we inadvertently upgraded prettier which apparently has different rules

-    "node_modules/prettier": {
-      "version": "2.0.5",
-      "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.0.5.tgz",
-      "integrity": "sha512-7PtVymN48hGcO4fGjybyBSIWDsLU4H4XlvOHfq91pz9kkGlonzwTfYkaIEwiRg/dAJF9YlbsduBAgtYLi+8cFg==",

+        "prettier": {
+          "version": "2.2.1",
+          "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.2.1.tgz",
+          "integrity": "sha512-PqyhM2yCjg/oKkFPtTGUojv7gnZAoG80ttl45O6x2Ug/rMJw4wcc9k6aaf2hibP7BGVCCM33gZoGjyvt9mm16Q==",
+          "dev": true
+        },

I'm not sure how that happened since we have the version in the package.json set to ^2.0.5 which if my memory serves me should only be loose on the tiny (last version number)

In any case, I'm going to push up something that fixes everything in a minute.

rudolph9 commented 3 years ago

I think we inadvertently upgraded prettier which apparently has different rules

-    "node_modules/prettier": {
-      "version": "2.0.5",
-      "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.0.5.tgz",
-      "integrity": "sha512-7PtVymN48hGcO4fGjybyBSIWDsLU4H4XlvOHfq91pz9kkGlonzwTfYkaIEwiRg/dAJF9YlbsduBAgtYLi+8cFg==",

+        "prettier": {
+          "version": "2.2.1",
+          "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.2.1.tgz",
+          "integrity": "sha512-PqyhM2yCjg/oKkFPtTGUojv7gnZAoG80ttl45O6x2Ug/rMJw4wcc9k6aaf2hibP7BGVCCM33gZoGjyvt9mm16Q==",
+          "dev": true
+        },

I'm not sure how that happened since we have the version in the package.json set to ^2.0.5 which if my memory serves me should only be loose on the tiny (last version number)

In any case, I'm going to push up something that fixes everything in a minute.

Well according to random blog post ~ only changes the tiny (or what they refer to as the patch) https://michaelsoolee.com/npm-package-tilde-caret/

I think we need to change this in all our repos since the formatting changes in later version.

stellarhoof commented 3 years ago

Looks like package-lock.json changed versions. Those number of changes are too high.

vstlouis commented 3 years ago

Looks like package-lock.json changed versions. Those number of changes are too high.

We should be on version 2 regardless if everyone is using node 16.4.0 and npm v7. @stellarhoof