futil-js / contexture-react

React components for building contexture interfaces
https://smartprocure.github.io/contexture-react
MIT License
6 stars 4 forks source link

bug fix, picker not from working with field `value` #540

Closed rudolph9 closed 2 years ago

rudolph9 commented 2 years ago

When a field had a key value this prevented the picker from working as expected. The follwing works around this by ensuring that value is a string and not an object which the exception the original logic when value is field.

Before cant select any group with a nested filed with key value (you can't select GroupA or GroupC): Screenshot 2022-03-03 at 12-02-08 Search Components FilterAdder - With NestedPicker ⋅ Storybook Screenshot 2022-03-03 at 12-02-30 Search Components FilterAdder - With NestedPicker ⋅ Storybook

After: Screenshot 2022-03-03 at 12-03-38 Search Components FilterAdder - With NestedPicker ⋅ Storybook Screenshot 2022-03-03 at 12-04-10 Search Components FilterAdder - With NestedPicker ⋅ Storybook Screenshot 2022-03-03 at 12-04-29 Search Components FilterAdder - With NestedPicker ⋅ Storybook

decrapifier commented 2 years ago
Warnings
:warning: The README has not been updated. Please update the README.
:warning: Branch being merged does not follow [Git Flow](http://nvie.com/posts/a-successful-git-branching-model/)
Messages
:book: Could not find any browser results.

Generated by :no_entry_sign: dangerJS against 2c311b6f02cdee28a57d3e8234f79e558106d4e1