futil-js / contexture-react

React components for building contexture interfaces
https://smartprocure.github.io/contexture-react
MIT License
6 stars 4 forks source link

Make greyVest the default theme #581

Closed stellarhoof closed 1 year ago

stellarhoof commented 1 year ago

Remove blueberry, material, and merge base theme into grey-vest

Had to break down ./src/utils/theme.js into multiple files because of circular imports

Merge https://github.com/smartprocure/contexture-react/pull/580 first

decrapifier commented 1 year ago
Warnings
:warning: :exclamation: This PR is BIG (+56 -1215) Please keep it below 500 net changes
Messages
:book: You reduced the total lines of code! Awesome! :+1:

Generated by :no_entry_sign: dangerJS against 4cc0245998648ca24c3cc39db3847a04e12dc87a

stellarhoof commented 1 year ago

material seems like it might be useful

Yeah but we've got so much code to maintain. I'd like to keep only what's absolutely necessary.

we might end up just dropping theming entirely since the components should drastically drop in complexity.

Yeah that's what I was thinking too. This PR is just the first step in that direction :)

stellarhoof commented 1 year ago

Will open again in the monorepo