Closed stellarhoof closed 1 year ago
Warnings | |
---|---|
:warning: | :exclamation: This PR is BIG (+1765 -1641) Please keep it below 500 net changes |
Generated by :no_entry_sign: dangerJS against 63e1071235dc8fb58d13f56278ab3a009e47d282
One more thing on this PR - I'm not sure removing the HOC and inlining loaders everywhere is net gain, especially since we also want to add generic hover to trigger a focus
/hover
client state. We probably still want a way to provide off the shelf contexture wrapping for those things - a HOC actually seems like a good solution there. Open to alternatives, but duplicating the logic everywhere seems worse to me.
With respect to loaders, I actually prefer the duplication because:
I'm not sure how the focus/hover feature would work so I can't comment there.
We can still export a hoc though, many libraries use this approach where they give you a few options on how to use their API (hook, hoc, render props, etc...)
Will open again in the monorepo
withNode
,withTheme
,withLoader
,withTreeLens
,contexturify
, andcontexturifyWithoutLoader
and mark them as deprecateduseNode
anduseTheme
, which are very simple and cover all the functionality provided by the deprecated onesLoader
component to the themeinject
react-recompose