futo-org / circles-android

Secure social networking for Android
GNU Affero General Public License v3.0
19 stars 4 forks source link

Cannot selective stopping rooms notifications from matrix.org #3

Open serrq opened 5 months ago

serrq commented 5 months ago

Steps to reproduce

I already had a Matrix account. So I made login with this one.

Additional info

I had to stop notifications from all rooms.

Application version

1.024 v8a

App Store name

F-Droid

Phone model

OnePlus CPH2399

Operating system version

Android 13

Homeserver

matrix.org

Contact info

No response

downeymj commented 4 months ago

I would add/clarify that this is not really limited to matrix.org. Anyone using an existing Matrix account for Circles will currently get duplicate notifications for non-Circles rooms; it seems that without a way to filter out non-Circles notifications right now, then the only other option is to disable all notifications for the client.

cvwright commented 4 months ago

This is a limitation of the Matrix spec. Push rules are per-account, not per-device. So every app connected to the account gets notifications for the same set of events.

Long-term it would be nice to have per-device push rules.

In the short term, it may be easier to use one account for chat and a different account for Circles.

Or I suppose we could add a "Chat" tab to Circles, and then you wouldn't need a separate chat app. But that's getting WAY ahead of ourselves!

downeymj commented 4 months ago

That makes sense. No easy way to filter notifications passed through the client? e.g., In Element, I can control notifications for each room/person using noisy flags and conversation flags that I could enable or disable for each person or room. Not sure but I don't think Circles handles its notifications in the same way, or yet.

cvwright commented 4 months ago

In Element, I can control notifications for each room/person using noisy flags and conversation flags that I could enable or disable for each person or room.

And it doesn't just change the push rules to exclude those rooms/accounts from notifications?

Thanks for the pointer. We will investigate more and see what we can do.

downeymj commented 4 months ago

No, I'm pretty sure it doesn't modify the server settings — think it is probably using this approach: https://developer.android.com/develop/ui/views/notifications/conversations