futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
630 stars 40 forks source link

Pinch & Zoom & Drag #1133

Open unoukujou opened 1 month ago

unoukujou commented 1 month ago

Use Cases

Pinch & Zoom is great, but the video can only be centered which often crops out the part of the video you want to zoom into. Need ability to do a two-finger drag to move the video around after zooming. This way I can zoom into the area of the video I want to see, such as the bottom-left corner for example.

Proposal

After pinch and zoom, we can use 2-fingers to drag the video around so that it is not fixed at center, but instead showing the part of the screen you want to see. For example, corners/sides/top/bottom which are cropped out when video is centered. But these might be the areas you want to zoom into, but cannot.

References

No response

McIrco95 commented 1 month ago

You can zoom in a little so that it fills the whole screen. (Blue border). If you zoom in more (blue border disapears) you can use 2-fingers to drag the video around.

unoukujou commented 1 month ago

You can zoom in a little so that it fills the whole screen. (Blue border). If you zoom in more (blue border disapears) you can use 2-fingers to drag the video around.

Not what I'm experiencing. After zooming in until blue border disappears, there is no way to drag video. 2-finger drag is being registered as pinch&zoom and only zooming in more/less depending if I drag up/down/left/right. Video is always zoomed to the exact center. No drag.

McIrco95 commented 1 month ago

For me both fingers need to be moved exactly the same amount in the same direction to drag. (I usually use 2 fingers directly next to another as one) And if one finger moves more or less then te other it switches to zooming. Imo that schould be changed so that it does not change from drag to zoom if i dont lift my fingers

unoukujou commented 1 month ago

Just tried it with super steady fingers, after 2 minutes I give up. Can't get it to drag no matter what. Only zooms in/out to the center.