futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
784 stars 49 forks source link

Skipping video portions it shouldn't #1482

Closed codyhood321 closed 1 week ago

codyhood321 commented 1 week ago

What happened?

I'm watching a Fully Ramblomatic video and it skipped immediately past the intro, and after a second, skipped again over "filler." I backed the video up and it immediately skipped again. I double checked my YouTube plugin and both those skip options are disabled.

The video this occured on: https://www.youtube.com/watch?v=18SbeaoMLJM

Screenshots with the notifications stating the skip occurring with the relevant settings visible. Screenshot_20241114_053839_Grayjay Screenshot_20241114_053846_Grayjay

Grayjay Version

264

What plugins are you seeing the problem on?

Youtube

Plugin Version

211

When do you experience the issue?

Relevant log output

No response

Zvonimir-FUTO commented 1 week ago

Couldn't reproduce this. Could you try setting them all to manual for example and then back to no skip? Also, were they set to no skip previously or did you change them after the update?

AtmosphericIgnition commented 1 week ago

I have also been experiencing this issue. Even though I have not enabled automatic skipping of intros and outros, they were getting automatically skipped. My workaround has been switching intros and outros from "No skip" to "Manual".

codyhood321 commented 1 week ago

Couldn't reproduce this. Could you try setting them all to manual for example and then back to no skip?

I full closed the app, restarted it, and didn't experience it again when starting the video again. However I do have sponsor skip enabled and there was a self promotion it skipped at the end of the video, could be related.

Also, were they set to no skip previously or did you change them after the update?

They have always been set to no skip.

WildFyr16 commented 1 week ago

I am also having this issue, it only started after the latest YouTube plugin update. Typically I don't like skipping parts in videos unless it is a specific scam sponsor, or something I would never interact with like mobile games. It seems like something in the latest update no longer checks what the status is in the settings before skipping

Zvonimir-FUTO commented 1 week ago

We are looking into this. Thank you guys for the feedback.

Zvonimir-FUTO commented 1 week ago

Released a hotfix in 212 to fix this issue so it should be fixed. I retested it and should be fine now but let us know.

AtmosphericIgnition commented 1 week ago

Thanks, seems to have fixed the issue for me, I'll let you know if I see it happening again.

Zvonimir-FUTO commented 1 week ago

Closing issue, if you are still encountering it feel free to reopen or open a new one.