search

futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
790 stars 49 forks source link

SponsorBlock segments skipping settings mismatch #1484

Open Philippe-Choquette opened 1 week ago

Philippe-Choquette commented 1 week ago 
          Closing issue, if you are still encountering it feel free to reopen or open a new one.

Originally posted by @Zvonimir-FUTO in https://github.com/futo-org/grayjay-android/issues/1482#issuecomment-2477464119

I originally had SponsorBlock configured to on "manual" for sponsors and self-promos.

After the update that made people create the issue above, like others, SponsorBlock was skipping everything, despite all segment types being on "No skip".

After the hotfix, the original behaviour was restored, with manual skipping only offered for sponsors and self-promos in the video player. However, in the SponsorBlock settings, every segment type is still on "No skip". In other words, there's a mismatch between the settings in the UI and the code in the back.

Screenshot_20241115_145220

Zvonimir-FUTO commented 1 week ago

Okay so it's just a UI bug, it functions properly under the hood. Marking this as low priority.

If you are encountering this issue, you can do what @MNarath1 suggested and temporarily change to different setting and revert back.