futo-org / grayjay-android

Read-only mirror of Grayjay repo for issue tracking
https://gitlab.futo.org/videostreaming/grayjay
Other
756 stars 48 forks source link

[Feature Request] Auto-generated closed captions are difficult to read quickly #450

Closed strapped-puppy closed 1 month ago

strapped-puppy commented 11 months ago

My request is for a fix to the way the auto-generated subtitles appear so they match the YouTube app's display of auto-generated subtitles. Currently, they do not and they are difficult to follow along.

mingyee2 commented 10 months ago

@strapped-puppy I’ve noticed that when the subtitles are actually supplied in the video and not autogenerated, they do appear how you describe you would like them. This suggests this is a consequence of how the autogeneration works. Do you have the same difficulty with autogenerated subtitles directly in YouTube?

strapped-puppy commented 10 months ago

You're correct, the behavior does only appear with auto-generated subtitles, however this is not how auto-generated subtitles appear in the YouTube app. They generate new subtitles top to bottom. And the subtitles then shift the bottom row upward to make room for the new line, as is traditional with closed captions.

I used this video to test the comparison, if I find a way to link a video comparing the two methods, I'll upload it later.

mingyee2 commented 10 months ago

@strapped-puppy You are correct about the subtitles appearing in a swapped order, shifting down rather than up, as is the norm. I too was bothered about that. But I wanted to clarify because the issue you submitted (and it still says it this way) is that the lines should appear together, which is not true even for YouTube. You might consider modifying the issue to be a fix to which way the subtitles are appended, unless you actually mean that you want the lines appearing together. If it is the latter, I might submit a separate issue about the wrong order, since that is easier for them to fix and might get rectified quickly.

strapped-puppy commented 10 months ago

Fixed, I hope that helps clarify the issue. Thanks for your help @mingyee2